Skip to content

cbm::algo::UnpackSts: Implemented walk correction. Improved asic enumeration.

Dominik Smith requested to merge d.smith/cbmroot:WalkCorrectionStsAsicFix into master

Extended version of !1200 (merged) that includes the change of asic enumeration scheme discussed therein. In my view, this version is more elegant and is the one that should be merged. Another advantage is that it more directly supports the current layout of walk-correction coefficient tables.

@fweig The changes were carried over to the XPU unpacker and the config class. Unfortunately we need the "number of asics per module" in this version in addition to the "number of asics per feb". In the legacy config class, I just hardcoded an additional number. In the new YAML scheme, I'm not sure I can change something without breaking anything else. In any case, in STS there are currently two FEBS per module, so "numAsicsPerMod = 2 * numAsicsPerFeb" always. I just applied this relation in ReadoutConfig.cxx. This seems like a hard feature of STS that will not change for the forseeable future, so we might be able to live with this hard coded relation. Maybe @p.-a.loizeau, @d.ramirez or @a.toia can comment.

I tested that the output of CbmTaskUnpack is preserved with these changes. @fweig weig, could you test this also for the XPU version?

Edited by Dominik Smith

Merge request reports