Skip to content

Add script to check rad length in various geo file sets + remove radlen CI

Pierre-Alain Loizeau requested to merge p.-a.loizeau/cbmroot:rad_len_gen_ci into master
  • Script checks all geo file in local copy by default (no arguments)
  • If git argument given, check all new geo files introduced by an eventual hash change compared to upstream/master
  • If other argument, use it as a tag to restrict the list of checked geo from local copy (e.g. using mcbm checks only all mCBM geometries)
  • Also add gitignore for macro geometry folder

Edit: Changed scope of MR to fixes to the existing files + new macro + removing CI tests not needed anymore Edit 2: Changed scope of MR to new macro + removing CI tests not needed anymore + cleanup of things moved to the geometrty repo

=> + Temp commit updating the hash to show the effect of the new test, should not be merged with this MR!!

Of interest to @e.clerkin and @v.friese

  1. Volker could probably be another reviewer, as I am a bit unsure of whether more should be added/done in this MR to address all the "old" geometries obviously having troubles (see lists at end of this description)
  2. What I am also unsure is what effect this "invalid radiation length" can have on the corresponding material budget map, if any (maybe it uses a different field and circumvent the problem)

Usage of the new script:

  • ./macro/geometry/check_radlen_all.sh git
    => check new geometries introduced by a hash change
  • ./macro/geometry/check_radlen_all.sh mcbm
    => check all geometries with mcbm in their name in the local folder
  • ./macro/geometry/check_radlen_all.sh
    => check all geometries in the local folder (including mCBM ones)

New Geometries making the CI test fail:

  • magnet/magnet_v22a.geo.root
  • magnet/magnet_v22b.geo.root

mCBM geometries failing a run of the script due to material (already found by @e.clerkin in #2658):

  • much/much_v22a_mcbm.geo.root
  • much/much_v22b_mcbm.geo.root
  • tof/tof_v21e_mcbm.geo.root
  • tof/tof_v21g_mcbm.geo.root
  • tof/tof_v21h_mcbm.geo.root
  • trd/trd_v21b_mcbm.geo.root

mCBM geometries failing a run of the script due to absent Top:

  • pipe/pipe_v19b_mcbm.geo.root
  • pipe/pipe_v19d_mcbm.geo.root
  • pipe/pipe_v19d_tb_mcbm.geo.root
  • pipe/pipe_v19e_mcbm.geo.root
  • pipe/pipe_v19e_tb_mcbm.geo.root
  • pipe/pipe_v19f_mcbm.geo.root
  • pipe/pipe_v19g_mcbm.geo.root
  • pipe/pipe_v19h_mcbm.geo.root
  • pipe/pipe_v20a_mcbm.geo.root
  • rich/rich_v18a_mcbm.geo.root

CBM geometries failing a run of the script due to material:

  • magnet/magnet_v18a.geo.root
  • magnet/magnet_v18b.geo.root
  • magnet/magnet_v20a.geo.root
  • magnet/magnet_v20b.geo.root
  • magnet/magnet_v21a.geo.root
  • magnet/magnet_v21b.geo.root
  • rich/rich_v17a_1e.geo.root
  • rich/rich_v17a_1e_nobpmt.geo.root
  • rich/rich_v17a_3e_full_mirror.geo.root
  • rich/rich_v17a_3e.geo.root

CBM geometries failing a run of the script due to absent Top:

  • much/much_v19c_sis100_1m_jpsi.geo.root
  • psd/psd_v18e.geo.root
  • psd/psd_v18f.geo.root
  • psd/psd_v18g.geo.root
  • psd/psd_v18h.geo.root
  • psd/psd_v18i.geo.root
  • psd/psd_v18j.geo.root
  • psd/psd_v18k.geo.root
  • psd/psd_v18l.geo.root
  • psd/psd_v18m.geo.root
  • tof/tof_v21a_1h_sis18.geo.root
  • tof/tof_v21b_1h_sis18.geo.root
Edited by Pierre-Alain Loizeau

Merge request reports